Fixed binding of command line flags #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be reproduced by running $ make run-debug
INFO[0000] Versions arch=amd64 identity=default.jaeger-operator jaeger=1.18.1 jaeger-operator=v1.18.1-10-g11a063f9 operator-sdk=v0.15.1 os=linux version=go1.14.3
INFO[0000] Auto-detected the platform platform=kubernetes
INFO[0000] Auto-detected ingress api ingress-api=networking
INFO[0000] Automatically adjusted the 'es-provision' flag es-provision=no
INFO[0000] Automatically adjusted the 'kafka-provision' flag kafka-provision=no
INFO[0000] The service account running this operator has the role 'system:auth-delegator', enabling OAuth Proxy's 'delegate-urls' option
INFO[0001] Install prometheus-operator in your cluster to create ServiceMonitor objects error="no ServiceMonitor registered with the API"
WARN[0002] failed to setup the Jaeger exporter error="write udp 127.0.0.1:47051->127.0.0.1:6831: write: connection refused"
^CFATA[0004] <nil>
exit status 1After this PR, there's one $ make run-debug
INFO[0000] Versions arch=amd64 identity=default.jaeger-operator jaeger=1.18.1 jaeger-operator=v1.18.1-11-g9e5a0cd2 operator-sdk=v0.15.1 os=linux version=go1.14.3
INFO[0000] Auto-detected the platform platform=kubernetes
INFO[0000] Auto-detected ingress api ingress-api=networking
INFO[0000] Automatically adjusted the 'es-provision' flag es-provision=no
INFO[0000] Automatically adjusted the 'kafka-provision' flag kafka-provision=no
INFO[0000] The service account running this operator has the role 'system:auth-delegator', enabling OAuth Proxy's 'delegate-urls' option
INFO[0001] Install prometheus-operator in your cluster to create ServiceMonitor objects error="no ServiceMonitor registered with the API"
DEBU[0001] Not running on OpenShift, so won't configure OAuthProxy imagestream.
WARN[0002] failed to setup the Jaeger exporter error="write udp 127.0.0.1:35449->127.0.0.1:6831: write: connection refused"
^CFATA[0002] <nil>
exit status 1This can also be easily reproduced/verified by setting |
|
@chlunde, would you like to review this one as well? |
pavolloffay
approved these changes
Jul 10, 2020
Fixes jaegertracing#1128 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/issue1128
branch
from
852a39c to
aa5c4b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 86 86
Lines 5350 5351 +1
=======================================
+ Hits 4720 4721 +1
Misses 466 466
Partials 164 164
Continue to review full report at Codecov.
|
kevinearls
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128 by binding the flags to Viper as part of the command execution, not during the building of the
Commandobject.Signed-off-by: Juraci Paixão Kröhling [email protected]